Peppy Poppies #14

janine9vn · 2025-09-13T02:20:23Z

No description provided.

Added frontend/ and backend/ Added dependency group for frontend and backend

Add basic setup to include directory to separate frontend and backend

Changed logic to accept images, relied on the library pillow for the heavylifting

fixed without any removed code now

should be fine now

Co-authored-by: i-am-unknown-81514525 <74453352+i-am-unknown-81514525@users.noreply.github.com>

Change Size of iframe

…2c077' git-subtree-dir: peppy-poppies git-subtree-mainline: 49c1216 git-subtree-split: 545d1ec

janine9vn

The Overall Picture

Very nicely done on the project. Despite having a few moving parts, your efforts to make it easy to run via docker paid off. There are some areas in the code where things could be improved, but there's nothing major.

README & Documentation

Your documentation does a great job of showcasing your project and showing the different parts of it. Explaining the breakdown of the different folders was helpful in reviewing your project. Setting up and running the project via docker was also a breeze, nicely done there. An area where your project could improve on is a little bit more explanation and description on how some can add their own questions and the format the question data set to take. The schema doesn't make it the clearest how things are supposed to go together and the format. You can probably piece it together by looking at the existing data set, but explicit documentation on that would go a long way.

Commits

Commits look mostly good. Some messages could use improvement, but that's a small piece of feedback overall. Some of your commits do a bit more than stated, like "add more error handling for runner.js" also alters some of the question set data. It's not the most atomic, but also not the biggest deal. But in those situations, I think it would be beneficial to list out some of the extra things the commit is doing in the commit body itself.

Code Quality

The code is generally easy to read and of good quality. I dive into specific instances in the comments where I have questions or I think things could be improved, so I would take a look there. Some of the file and folder structures seem a bit odd given what's in them. I have specific comments on it you can look at.

janine9vn · 2025-10-23T03:12:45Z

peppy-poppies/crypto/_test.py

+
+from key import export_key, generate_key_pair, import_private_key, import_public_key
+
+if __name__ == "__main__":


What is this file specifically testing for?

janine9vn · 2025-10-23T03:15:44Z

peppy-poppies/crypto/jwt_generate.py

+        self._issuer: str = issuer
+        self._priv: bytes = get_pem(private_key)


I'm not sure these typehints are the most helpful as they can be reliably inferred.

janine9vn · 2025-10-23T03:17:34Z

peppy-poppies/crypto/jwt_generate.py

+        data["nbf"] = current.timestamp()  # Not before timestamp
+        data["exp"] = (current + timedelta(seconds=valid_duration)).timestamp()  # Expiration timestamp
+        data["aud"] = website  # Audience (the website domain)
+        data["iss"] = self._issuer  # The issue (the CAPTCHA server domain)
+        data["iat"] = current.timestamp()  # Issue timestamp


Is there a reason the dict keys are kept to 3 letters? It's not immediately clear why they're seemingly hard limited to a length of 3 and therefore need comments explaining what they are.

The reason is JWT just uses those 3 characters as standard... I would like to not use 3 characters otherwise (since it's confusing but it's also the only way the library can properly validate it)

janine9vn · 2025-10-23T03:20:50Z

peppy-poppies/frontend/captcha/captcha.py

+    print(parsed)
+    query_dict = urllib.parse.parse_qs(parsed)
+    print(query_dict)


Are these leftover print statements?

janine9vn · 2025-10-23T03:24:11Z

peppy-poppies/frontend/captcha/captcha.py

+    print(parsed)
+    query_dict = urllib.parse.parse_qs(parsed)
+    print(query_dict)
+    challenge_id = query_dict.get("challenge_id")


What are the possible options challenge_id can be? Seemingly it's either a list or a string?
It's not clear why if it's not eventually a string, then it raises a value error instead of some custom error.

Additionally, based on the function docstring, it's not clear what makes it a valid string or an invalid string.

janine9vn · 2025-10-23T04:15:34Z

peppy-poppies/server/captcha/lib/dependencies.py

+from sqlalchemy.ext.asyncio import AsyncSession
+
+
+async def provide_challenge_service(  # noqa: D103


Same comment as I had with the backend/lib/ folder, it's not clear why this folder-file structure was used.

janine9vn · 2025-10-23T04:17:05Z

peppy-poppies/server/captcha/lib/utils.py

+    )
+
+
+def question_generator(question_set: QuestionSet, seed: int | None = None) -> GeneratedQuestion:  # noqa: C901, PLR0915


This feels less like a utility that could potentially be used elsewhere and more like something that is necessary and instrinsic to the challenge controller. I would not expect to find this function here and also take up the majority of this file.

janine9vn · 2025-10-23T04:19:06Z

peppy-poppies/server/captcha/schema/questions.py

+class Part(Struct):
+    """A part in question_set.json."""
+
+    question: str
+    validator: str
+    range: Ranges


I was hoping this would have more information on what it takes to build a valid question, specifically with the parts. But this doesn't quite have enough information to know how it all comes together. Some more information either here or in a README somewhere about how to format additional questions would be nice.

This comment can also be applied to some other classes in this file as well.

janine9vn · 2025-10-23T23:02:47Z

peppy-poppies/build.py

+try:
+    from dotenv import load_dotenv
+
+    load_dotenv(override=True)
+except ImportError:
+    pass


Should this raise some sort of warning if the .env file isn't able to be loaded? If this is intended to be development only, should there be some sort of flag to read/set?

janine9vn · 2025-10-23T23:04:26Z

peppy-poppies/pyproject.toml

+# This section contains metadata about your project.
+# Don't forget to change the name, description, and authors to match your project!
+name = "pycj12-peppy-poppies"
+description = "Add your description here"


Maybe change the description? ;P

Oh lol, looks like we overlooked that.

DragonSenseiGuy · 2025-10-24T11:22:06Z

Thanks for the feedback! Our team will look into it.

i-am-unknown-81514525 and others added 30 commits August 5, 2025 22:34

Initial commit

a83880d

Test webhook

e75c2b2

Update pyproject.toml

ec0bd8f

Set author in pyproject.toml

fdcf733

Update uv.lock and add pylock.toml

fc723fe

Add cmd.md for common command used for development

6b5a8a9

Remove samples folder for other package manager

90f7b27

Add new author for new code jam member

4901b85

Add basic setup to include directory to seperate frontend and backend

1a22bd6

Added frontend/ and backend/ Added dependency group for frontend and backend

Add pyscript as dependency

2ca59e6

Add default groups for uv

f8d27fc

Merge pull request #1 from i-am-unknown-81514525/setup

5d49a6e

Add basic setup to include directory to separate frontend and backend

Update dependency and add crypto module

6944cee

Add Ed25519 key generation

20d0caa

Add cryptography itself to also be required dependency

fa2a0ec

Optimize the logic

6f4b885

Fix linting

92bbd83

chore: update doc strings

f74587f

Add JWT token generation base on private key

be7857a

Reformat and add docstring

0ec0509

More ruff reformat

7f922f1

Add listening for cookie change from website and redirect

b7c0b8a

Complete untested captcha_handler

4c39080

Set require auth cookie to false and delete it after auth

bb0cf6c

feat: initial ui

1d220a5

Add captcha script to get challenge

e951691

Add create_proxy for get_challenge

3356aea

backend

ebc13a5

get endpoint

b83e8a4

tayvona's error message ui changes

5d8e322

fiwam and others added 28 commits August 18, 2025 15:41

Update challenge.py

384b0c1

Changed logic to accept images, relied on the library pillow for the heavylifting

Update captcha.py

9b8fd20

fixed without any removed code now

Update challenge.py

85442b1

should be fine now

Fix some part

cb29acd

Change to use image

250750d

Update width and height settings

506eb38

Implement and link image together

59a8b87

Add /logout and /me endpoint

a22260f

Co-authored-by: i-am-unknown-81514525 <74453352+i-am-unknown-81514525@users.noreply.github.com>

Fix JWT prevent static resource load and JWT actually work now

59ffacf

use proper auth

d5d9a75

Remove timeout execution

7cd3f1a

Remove unused multiprocessing, os import

f408b07

Fix on http context and Host header missing protocol

ab21daa

Use consistent local IP

6b3007b

Fix /api/auth/me endpoint

c8e57e1

Fix inconsistent login button color

39efae5

Improve phrasing for some question

e8f5cd9

Add font and remove the image write

876301f

Fix linting

a1085de

Remove debug file

427d905

Fix other pre-commit check

31416c1

Fix inconsistent IP on .env.example

ae0f53e

Use consistent IP

bf26c13

Change Size of iframe

b2f806e

Merge pull request #27 from i-am-unknown-81514525/dragon

e2a825b

Change Size of iframe

Add updated README.md with a video demo

7ae13b2

Remove Gemini Key and Change Spelling error

545d1ec

Add 'peppy-poppies/' from commit '545d1ecbbe51f1df20adf1c1df159ef0e0e…

9cea873

…2c077' git-subtree-dir: peppy-poppies git-subtree-mainline: 49c1216 git-subtree-split: 545d1ec

janine9vn commented Oct 24, 2025

View reviewed changes


		from key import export_key, generate_key_pair, import_private_key, import_public_key

		if __name__ == "__main__":

		self._issuer: str = issuer
		self._priv: bytes = get_pem(private_key)

		from sqlalchemy.ext.asyncio import AsyncSession


		async def provide_challenge_service( # noqa: D103

		)


		def question_generator(question_set: QuestionSet, seed: int \| None = None) -> GeneratedQuestion: # noqa: C901, PLR0915

Uh oh!

Peppy Poppies #14

Are you sure you want to change the base?

Peppy Poppies #14

Uh oh!

Conversation

janine9vn commented Sep 13, 2025

Uh oh!

janine9vn left a comment

Choose a reason for hiding this comment

The Overall Picture

README & Documentation

Commits

Code Quality

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

DragonSenseiGuy commented Oct 24, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants